Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Most active Places Sort by #570

Merged
merged 7 commits into from
Dec 17, 2024
Merged

fix: Most active Places Sort by #570

merged 7 commits into from
Dec 17, 2024

Conversation

cyaiox
Copy link
Contributor

@cyaiox cyaiox commented Dec 16, 2024

This PR fixes the sort by for most active places and merges the data from the legacy realms and the ea archipelago.

Copy link

github-actions bot commented Dec 17, 2024

Pull Request Test Coverage Report for Build 12381110487

Details

  • 450 of 450 (100.0%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 94.414%

Totals Coverage Status
Change from base Build 12303022893: 0.4%
Covered Lines: 15932
Relevant Lines: 16675

💛 - Coveralls

@cyaiox cyaiox requested a review from braianj December 17, 2024 14:34
Comment on lines 76 to 89
const processScene = (scene: HotScene, sceneMap: Map<string, HotScene>) => {
const key = `${scene.baseCoords[0]},${scene.baseCoords[1]}`
if (sceneMap.has(key)) {
// If scene exists, sum the users count
const existingScene = sceneMap.get(key)!
sceneMap.set(key, {
...existingScene,
usersTotalCount:
existingScene.usersTotalCount + scene.usersTotalCount,
})
} else {
sceneMap.set(key, scene)
}
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WDYT about moving this outside and maybe add a test?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! ty for the feedback

@cyaiox cyaiox merged commit 74aa58a into master Dec 17, 2024
2 checks passed
@cyaiox cyaiox deleted the fix/most-active-places-sort branch December 17, 2024 22:07
cyaiox added a commit that referenced this pull request Dec 20, 2024
This reverts commit 74aa58a.
cyaiox added a commit that referenced this pull request Dec 20, 2024
This reverts commit 74aa58a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants